search

schmittjoh / JMSI18nRoutingBundle

Allows you to internationalize your routing
http://jmsyst.com/bundles/JMSI18nRoutingBundle
358 stars 159 forks source link

Don't call Extension::addClassesToCompile() on php versions greater than 7 #202

Closed kbond closed 7 years ago

kbond commented 7 years ago

This method is deprecated in 3.3. See https://github.com/symfony/symfony/pull/20735

deguif commented 7 years ago

The title is wrong. It should be: Don't call Extension::addClassesToCompile() on php versions greater than 7

kbond commented 7 years ago

Good catch, thanks @deguif!

acrobat commented 7 years ago

@acasademont is it possible to have this merged and have a release with this fix? This currently triggers deprecation warnings in the released symfony 3.3. Thanks!

XWB commented 7 years ago

Ping @acasademont

acasademont commented 7 years ago

oops, sorry guys, missed this. Yes sure, I'll take a look at it ASAP :)

acasademont commented 7 years ago

Hi all! Tests are failing miserably right now with Symfony >= 3.0. It's not related with this patch but it would be nice to fix them before releasing a new version. Working on it.

XWB commented 7 years ago

@acasademont Any updates? :)

deguif commented 7 years ago

See #207 about fixing the tests for Symfony 3.0.

Maybe this would allow @acasademont to merge this one.

acasademont commented 7 years ago

Patch merged thank you all for this! and sorry for the very late merge @XWB @acrobat @kbond @deguif

acrobat commented 7 years ago

No problem @acasademont! Thanks for the merge and release!

XWB commented 7 years ago

Thank you @acasademont :)