Closed deguif closed 7 years ago
Tests are still failing on PHP 5.3
but that's related to memory used by composer.
HHVM test failure can be fixed by setting the dist option in the build matrix in the .travis.yml
matrix:
include:
- php: hhvm
dist: trusty
~I would even suggest adding php 5.3 to the allowed failures and move the minimum php version up to 5.6~
@deguif I think you can simply fix the php 5.3 build by commiting the composer.lock, because it is missing. So the composer install in the travis build will effectively be a composer update. Thus requiring more memory
I just updated .travis.yml
to configure php memory_limit, this should fix PHP 5.3
failure.
I can confirm now that PHP 5.3
tests are now succeeding.
Just HHVM
tests are still failing.
Thanks @acrobat , I updated the config for HHVM tests on .travis.yml
HHVM
tests suite has launched after composer install, that's better than before, but there are still some weird errors.
When downgrading HHVM
to 3.6, all tests are green.
It seems like latest LTS HHVM 3.18
version is not able to make test pass.
I found this issue on HHVM that was reported by @nicolas-grekas https://github.com/facebook/hhvm/issues/7722
This should be fixed with the new 3.20.2 HHVM
version.
For the moment, I used version 3.15
of HHVM
I would even say to remove support for HHVM as symfony did also drop support for it. So we could keep testing on HHVM but move it to the allow failures
Hi @deguif and @acrobat thanks a lot for this, I found some time today to review all these patches.
I deliberately chose to use full namespaced class name for
Scope
andRequestStack
as depending on which Symfony version the tests are run , they could not exist.RequestStack
was introduced on Symfony 2.4Scope
was removed on Symfony 3.0