schmittjoh / JMSI18nRoutingBundle

Allows you to internationalize your routing

http://jmsyst.com/bundles/JMSI18nRoutingBundle

357 stars 159 forks source link

Symfony 4 support #214

Closed bodorszilard closed 6 years ago

bodorszilard commented 6 years ago

SymfonyConHackday2017

bodorszilard commented 6 years ago

@alcaeus Done

alcaeus commented 6 years ago

Test failures still look unrelated, but dev build tests Symfony 3.4 probably due to version constraints in other dependencies.

alcaeus commented 6 years ago

@bodorszilard this is probably nothing you can fix: composer would pick Symfony 4.0 (this composer.json allows it) if all dependencies allowed it. Apparently, some other dependency doesn't allow Symfony 4 so composer installs the latest possible version of 3.x, which is 3.4.0-dev. You can remove the last commit as it doesn't change anything.

If test failures are in fact not related to these changes (a maintainer will have to make sure of that), the PR can be merged regardless of the Symfony version tested.

bodorszilard commented 6 years ago

okay, thanks @alcaeus

bravik commented 6 years ago

In addition "jms_i18n_routing.loader" should be declared as public in JMSI18nRoutingBundle/Resources/config/services.xml: <service id="jms_i18n_routing.loader" class="%jms_i18n_routing.loader.class%" public="true"> otherwise there is an error from this issue: issue215

acasademont commented 6 years ago

SF4 is now supported, thx!