add support for symfony 3.4 and symfony 4.0

[theedov]

Hi,

please add support for Symfony 3.4 and Symfony 4.0

Current error:

The "jms_i18n_routing.loader" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.

[bravik]

"jms_i18n_routing.loader" should be declared as public Solved by editing the following line in JMSI18nRoutingBundle/Resources/config/services.xml: <service id="jms_i18n_routing.loader" class="%jms_i18n_routing.loader.class%" public="true">

[acasademont]

hi guys! i'll try to work it out and review all these SF4 compatibility this weekend :) Thx for the patches!

[acasademont]

Done :)

[kironet]

@acasademont Hi, I don't know why, but I'm still having the same error. Symfony 3.4 My composer:

    "require": {
        "php": "^7.1.3",
        "friendsofsymfony/user-bundle": "^2.0",
        "javiereguiluz/easyslugger": "^1.0",
        "jms/i18n-routing-bundle": "^2.0",
        "knplabs/knp-paginator-bundle": "^2.6",
        "liip/imagine-bundle": "^2.0@dev",
        "sensio/framework-extra-bundle": "^5.0",
        "sensio/generator-bundle": "^3.1",
        "symfony/asset": "^3.4",
        "symfony/console": "^3.4",
        "symfony/form": "^3.4",
        "symfony/framework-bundle": "^3.4",
        "symfony/maker-bundle": "^1.0",
        "symfony/monolog-bundle": "^3.1",
        "symfony/orm-pack": "^1.0",
        "symfony/polyfill-apcu": "^1.6",
        "symfony/polyfill-php71": "^1.6",
        "symfony/profiler-pack": "^1.0",
        "symfony/security-bundle": "^3.4",
        "symfony/swiftmailer-bundle": "^3.1",
        "symfony/translation": "^3.4",
        "symfony/twig-bundle": "^3.4",
        "symfony/validator": "^3.4",
        "symfony/yaml": "^3.4"
    },

If I use "jms/i18n-routing-bundle": "dev-master", Error is that bundle requires 4.0

[web-monster]

Please, Add support version 3.4

[acasademont]

As it has a BC break you need to use ^3.0!

On Sun, 3 Dec 2017 at 15:08, Dmitry notifications@github.com wrote:

Please, Add support version 3.4

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/schmittjoh/JMSI18nRoutingBundle/issues/215#issuecomment-348772999, or mute the thread https://github.com/notifications/unsubscribe-auth/AAyWvX7WQD95CX02Dh86IeSzw8Mq4stqks5s8qtrgaJpZM4QuZ0C .

[pdias]

This bundle in Sf3.4 will continue without correcting this warning, because most bundles in Sf3. continue to use symfony/framework-bundle 3. and now is required "symfony/framework-bundle": "^4.0" .

I do not know if it will be possible ... but why not create a tag 2.0.2 where only correct the services.xml (public="true") as already mentioned?!!!

[acasademont]

@pdias done, I've tagged 2.0.2 with the service fix

[pdias]

Thanks @acasademont

[edurenye]

I'm still having the following error:

User Deprecated: The "router" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0

With the version 2.0.2 and Symfony 3.4.1

[acasademont]

@edurenye seems like this is a different issue, could you please open up a new one?

[edurenye]

Done.