search

schmittjoh / JMSI18nRoutingBundle

Allows you to internationalize your routing
http://jmsyst.com/bundles/JMSI18nRoutingBundle
357 stars 159 forks source link

The `router` alias is public #217

Closed sroze closed 6 years ago

sroze commented 6 years ago

This is fix #216

acasademont commented 6 years ago

Thx @sroze!

raphaChoquet commented 6 years ago

For information, this fix isn't compatible with Symfony 2 and 3 because setAlias return null, therefore you can't set public at true.
You have to use the method getAlias to retrieve it and then set public at true.

$container->setAlias('router', 'jms_i18n_routing.router');    
$container->getAlias('router')->setPublic(true);
acasademont commented 6 years ago

@raphaChoquet noticed it this morning, the fix is already commited and tagged :=)

sroze commented 6 years ago

Great, thanks for sorting it. Sorry for the BC.

raphaChoquet commented 6 years ago

Ok thx! :) i can update my repo then !

acasademont commented 6 years ago

yep, sorry for that, having so many different SF versions to test on is a PITA sometimes :p

raphaChoquet commented 6 years ago

Yes i understand, thx for have it done rapid!