search

schmittjoh / JMSI18nRoutingBundle

Allows you to internationalize your routing
http://jmsyst.com/bundles/JMSI18nRoutingBundle
358 stars 159 forks source link

[Fix] Changed localeChoosingListener on kernel request #221

Open Losams opened 6 years ago

Losams commented 6 years ago

Type : [Fix] Problem with the welcome page on symfony 3.4.7

On symfony 3.4.7, the welcome page didn't throw an exception anymore (in debug mode). The localeChoosingListener has been put in kernel.request instead.

grizzlylab commented 6 years ago

Thank you @Losams for you work, I hope this can be merged soon.

acasademont commented 6 years ago

Thanks @Losams will try to take a look at the issue this weekend.

XWB commented 6 years ago

@acasademont Any updates? :)

acasademont commented 6 years ago

hey guys, so sorry for the late review. I'm trying to understand what's the underlying problem here, one test is also failing due to the patch. Could you please elaborate a bit more @Losams?

Losams commented 6 years ago

Yes IDK why the "testNoCookieOnError" crashed, to be honest I didn't check so far. All I can say is what I said on the commit : "On symfony 3.4.7, the welcome page didn't throw an exception anymore (in debug mode)." So the localeChoosingListener didn't fire anymore (only on debug env). For that I changed the dispatch to kernel.request