search

schmittjoh / JMSI18nRoutingBundle

Allows you to internationalize your routing
http://jmsyst.com/bundles/JMSI18nRoutingBundle
358 stars 159 forks source link

[Router] Adapt code since Symfony 4 is now required #224

Open deguif opened 6 years ago

deguif commented 6 years ago

This PR removes compatibility with Symfony 2 in Router class. I also update the code to be more Symfony 4.

Breaking change is that now the I18nLoader service is injected instead of the id.

acasademont commented 6 years ago

Hi @deguif thanks for the patch! However, as you said, this is a BC change (not sure how many people use a custom I18nRouter though) and I'd like not to merge it unless is solving some kind of bug.

deguif commented 6 years ago

I just updated the code to remove the BC change related to I18nLoader injection, this will remains as before.