search

schmittjoh / JMSI18nRoutingBundle

Allows you to internationalize your routing
http://jmsyst.com/bundles/JMSI18nRoutingBundle
358 stars 159 forks source link

Breaks with Symfony 4.2.8 #237

Closed TamasSzigeti closed 5 years ago

TamasSzigeti commented 5 years ago

This PR breaks JMSI18nRoutingBundle https://github.com/symfony/symfony/pull/31023/files

Fatal error: Access level to JMS\I18nRoutingBundle\Router\I18nRouter::$defaultLocale must be protected (as in class Symfony\Bundle\FrameworkBundle\Routing\Router) or weaker in vendor/jms/i18n-routing-bundle/JMS/I18nRoutingBundle/Router/I18nRouter.php on line 293

monro93 commented 5 years ago

This issue should be fixed in https://github.com/schmittjoh/JMSI18nRoutingBundle/pull/236

A workaround is to set the symfony/routing version to 4.2.7 in your composer.json:

"symfony/routing": "4.2.7"

TamasSzigeti commented 5 years ago

Thank you!