search

schmittjoh / JMSI18nRoutingBundle

Allows you to internationalize your routing
http://jmsyst.com/bundles/JMSI18nRoutingBundle
358 stars 159 forks source link

Fix symfony 5 deprecations #242

Closed florianajir closed 4 years ago

florianajir commented 4 years ago

User Deprecated: The default value of the "$secure" and "$samesite" arguments of "Symfony\Component\HttpFoundation\Cookie::__construct"'s constructor will respectively change from "false" to "null" and from "null" to "lax" in Symfony 5.0, you should define their values explicitly or use "Cookie::create()" instead

from JMS/I18nRoutingBundle/EventListener/CookieSettingListener.php:47

lightcoresystems commented 4 years ago

Hi, i did some updates in PR #243 , waiting for merge :)

denis1994 commented 4 years ago

I'm also waiting for an update to this package because this is the only package why I can't upgrade to Symfony 5

acasademont commented 4 years ago

Hi all! Sorry for the huge delay. I'll try to get this merged asap. But also, I think it's time to consider this package as obsolete, Symfony already includes a number of i18n features.

acasademont commented 4 years ago

Merged and a new 3.0.4 tag has been created. Thank you all!!