schmittjoh / JMSJobQueueBundle

Run and Schedule Symfony Console Commands as Background Jobs
http://jmsyst.com/bundles/JMSJobQueueBundle
334 stars 254 forks source link

Add missing '_display_code_snippet' variable #186

Open ianfp opened 6 years ago

ianfp commented 6 years ago

This is required for compatibility with Symfony 3.3.9 (and earlier?). See

https://github.com/symfony/symfony/issues/24265

kopaygorodsky commented 6 years ago

Would be nice to have this fix in master.

kick-the-bucket commented 6 years ago

About the failing build: This bundle states that it supports PHP 5.5.0 || ^7.0, but strangely has a composer.lock commited with a lot of dependencies, that need at least 5.5.9 or even 5.6. For a library trying to support different platforms and package versions the composer.lock file should either be omitted at all or generated using the lowest PHP version supported.