schmittjoh / JMSJobQueueBundle

Run and Schedule Symfony Console Commands as Background Jobs
http://jmsyst.com/bundles/JMSJobQueueBundle
335 stars 254 forks source link

Changed ProcessBuilder to Process in RunCommand (Symfony 3.4 Compatibility) #195

Closed DirkBaumeister closed 6 years ago

DirkBaumeister commented 6 years ago

Because there is a deprectation warning when you use the ProcessBuilder class in Symfony 3.4 (Because it gets removed in Symfony 4.0), I changed the code segments in this specific Command to call the Process class directly. The behaviour is still the same.

cristoforocervino commented 6 years ago

Please, merge this. This pull request is necessary (+ composer.json file edit) also for Symfony 4.0

schmittjoh commented 6 years ago

Thanks for the PR, the latest version now supports 3.4 without issues.