search

schmittjoh / JMSJobQueueBundle

Run and Schedule Symfony Console Commands as Background Jobs
http://jmsyst.com/bundles/JMSJobQueueBundle
334 stars 254 forks source link

Incorrect documentation regarding scheduling cron job with a CronCommand #227

Closed mtuck063 closed 4 years ago

mtuck063 commented 5 years ago

With regards to scheduled_jobs.rst, the documentation suggest that you must implement JMS\JobQueueBundle\Command\CronCommand when in fact it is JMS\JobQueueBundle\Console\CronCommand and secondly when implementing the CronCommand you must also tag the concrete class with jms_job_queue.cron_command, however this is not stated in the documentation.

karlzakhary commented 4 years ago

and secondly when implementing the CronCommand you must also tag the concrete class with jms_job_queue.cron_command >

Man, you're amazing!

karlzakhary commented 4 years ago

@schmittjoh I think that should be updated since I have really stumbled for a while because of that missing procedure

schmittjoh commented 4 years ago

Is there a pull-request for the docs already?

karlzakhary commented 4 years ago

Is there a pull-request for the docs already?

Yes, https://github.com/schmittjoh/JMSJobQueueBundle/pull/235

schmittjoh commented 4 years ago

Thanks, closing this here :+1: