search

schmittjoh / JMSSecurityExtraBundle

Enhances the Symfony2 Security Component with several new features
http://jmsyst.com/bundles/JMSSecurityExtraBundle
255 stars 100 forks source link

Make it compatible with Symfony 3.0 #194

Closed francoispluchino closed 8 years ago

francoispluchino commented 8 years ago

Is it planned to make it compatible this Bundle with Symfony 3.0?

kniziol commented 8 years ago

That's good and important question Is there any info when it could be?

Wirone commented 8 years ago

Same question here. I got deprecation warnings from this bundle.

pinouf commented 8 years ago

+1

JoydS commented 8 years ago

+1

schmittjoh commented 8 years ago

Please provide a pull-request if you need Symfony3 support before I get to it.

maurotrentini commented 8 years ago

+1

sblondeau commented 8 years ago

@schmittjoh I think the pull-request is ready since a while. Thx in advance to merge it ! Have a nice week-end

GuilhemN commented 8 years ago

https://github.com/schmittjoh/JMSSecurityExtraBundle/pull/202 merged ! Please test dev-master on your projects and tell me if you have any errors :-)

boast commented 8 years ago

Thank you for your efforts @Ener-Getick !!

Sadly, https://github.com/schmittjoh/JMSDiExtraBundle is not ready for Symfony 3.0 (I recall a patch / PR should be available, though). The JMSDiExtraBundle also restricts the JMSAopBundle to version 1.1, whereas 1.2 would be available and is 3.0 ready.

GuilhemN commented 8 years ago

Yeah this is in progress too ☺

boast commented 8 years ago

:-) nice, I was just yesterday thinking "bummer, that probably takes a while to migrate all those repos, lets go back to 2.8". 3.0? Here I come!

francoispluchino commented 8 years ago

@Ener-Getick jms/di-extra-bundle:1.6.0 (or dev-master) required Symfony ~2.1, not ~2.3|~3.0.

It's therefore impossible to install this bundle with Symfony 3 for the moment.

Waiting to merge schmittjoh/JMSDiExtraBundle#227.

GuilhemN commented 8 years ago

@francoispluchino see https://github.com/schmittjoh/JMSDiExtraBundle/pull/227 ;-)

francoispluchino commented 8 years ago

@Ener-Getick Yes, but this PR is not merged for the moment :). Strange that the tests successfully pass with Symfony 3, while a dependency require Symfony 2 (besides, the tests do not pass on Travis in the section 'allowed failures').

It would have been better to wait the merge of the PR of JMSDiExtraBundle before release a beta version of this bundle?

GuilhemN commented 8 years ago

@francoispluchino The problem is that JMSDiExtraBundle depends on JMSSecurityExtraBundle too so if I didn't release one of them, we would be locked...

francoispluchino commented 8 years ago

@Ener-Getick Indeed, I hadn't seen that it was required for the dev. In this case I understand :-).

Thank you for your efforts!

GuilhemN commented 8 years ago

@francoispluchino I merged https://github.com/schmittjoh/JMSDiExtraBundle/pull/227 ;-)

francoispluchino commented 8 years ago

@Ener-Getick Thank you !!!

GuilhemN commented 8 years ago

@francoispluchino I will see if there are PRs waiting to be merged before creating an RC phase.