Stop collecting metadata from cache

schmittjoh / JMSSerializerBundle

Easily serialize, and deserialize data of any complexity (supports XML, JSON, YAML)

http://jmsyst.com/bundles/JMSSerializerBundle

MIT License

1.8k stars 311 forks source link

Stop collecting metadata from cache #900

Closed scyzoryck closed 1 year ago

scyzoryck commented 1 year ago

Q	A
Bug fix?	yes
New feature?	no
Doc updated	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#899
License	MIT

Instead of collecting data about metadata from cache we can decorate the factory itself.

goetas commented 1 year ago

good idea

smoench commented 1 year ago

@goetas Unfortunately it was not a good idea merging it without a successfully test run. Currently the latest release is broken due to:

TypeError : JMS\SerializerBundle\Debug\DataCollector::__construct(): Argument #4 ($metadataDriver) must be of type JMS\SerializerBundle\Debug\TraceableDriver, JMS\SerializerBundle\Debug\TraceableMetadataFactory given,

Please consider merging #897 to enable the CI checks again. When it is merged I can provide a fix.

jdreesen commented 1 year ago

I just noticed that all pipelines are failing, too, and created a PR #901 to fix this. I now closed it again, as it's a duplicate of #897.