search

schmittjoh / JMSSerializerBundle

Easily serialize, and deserialize data of any complexity (supports XML, JSON, YAML)
http://jmsyst.com/bundles/JMSSerializerBundle
MIT License
1.8k stars 311 forks source link

Fix #923 Enabled support for DefaultValuePropertyDriver #924

Closed dbojdo closed 10 months ago

dbojdo commented 1 year ago
Q A
Bug fix? no
New feature? yes
Doc updated yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #923
License MIT
dbojdo commented 1 year ago

Well, we may go the same way as for the enums. Introduce a new config property like: default_value_support: true/false (false by default) and then respect it in the extension.

scyzoryck commented 1 year ago

I think it will be better way to safely release it as non major release :)

dbojdo commented 1 year ago

I think it will be better way to safely release it as non major release :)

Good for me!

goetas commented 1 year ago

@dbojdo let me know then the config option is implemented, we can merge it

Kozzi11 commented 1 year ago

@dbojdo what is the status of this? Are you willing to continue on this PR (add support for config) or can somebody else continue on it?

dbojdo commented 1 year ago

Hey! Don't mind someone else to take over as I'm super short on time now. There's not much to be done but can't afford the context switch now.

Kozzi11 commented 1 year ago

Perfect, I have cretead PR (https://github.com/dbojdo/JMSSerializerBundle/pull/1) to your branch with few modification can you merge it so changes will be reflected here? Thank you @dbojdo

dbojdo commented 1 year ago

@Kozzi11 this that's been merged, thanks for your help!

Kozzi11 commented 11 months ago

@goetas ping