use Fully Qualified Extension Class Name

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids

http://jmsyst.com/bundles/JMSTranslationBundle

426 stars 292 forks source link

use Fully Qualified Extension Class Name #404

Closed sword closed 7 years ago

sword commented 8 years ago

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	possibly
Deprecations?	no
Tests pass?	?
Fixed tickets
License	Apache2

Description

Deprecation warning: Referencing the "JMS\TranslationBundle\Twig\TranslationExtension" extension by its name (defined by getName()) is deprecated since 1.26 and will be removed in Twig 2.0. Use the Fully Qualified Extension Class Name instead.

Todos

[ ] Tests
[ ] Documentation
[ ] Changelog

Nyholm commented 8 years ago

Thank you for this PR. But will this work on twig 1.12? https://github.com/schmittjoh/JMSTranslationBundle/blob/1.3.1/composer.json#L27

gnat42 commented 7 years ago

We've bumped the twig minimum requirement to 1.27 - this should no longer be an issue.