Use `same as` for twig 1.21 deprecated compliance

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids

http://jmsyst.com/bundles/JMSTranslationBundle

426 stars 292 forks source link

Use `same as` for twig 1.21 deprecated compliance #434

Closed LordWeedlle closed 7 years ago

LordWeedlle commented 7 years ago

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Tests pass?	no :/ but they don't pass for master either...
Fixed tickets
License	Apache2

Description

Replaced deprecated twig function sameas (since 1.21) by recommended same as

LordWeedlle commented 7 years ago

I've got a problem there, I got exactly same fails when running unit tests in local from your master branch (i.e: without my commit modifications) Is this normal ? Do you get same fails as me ?

LordWeedlle commented 7 years ago

Well thanks for all those who left comments there and made this repository really active! I'm proud to try to contribute to repositories like this one! Kappa If I should resume this repository in three word it would be : Interchange of ideas

P.S: :fu: 🤓 :fu:

gnat42 commented 7 years ago

Thanks for contributing @LordWeedlle