search

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Use \Twig_BaseNodeVisitor instead of duplicated visitors code #441

Closed emodric closed 7 years ago

emodric commented 7 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #425
License Apache2

Description

Okay, so it turns out there is a base class \Twig_BaseNodeVisitor in Twig that assists in BC between 1.x and 2.x node visitors (https://github.com/twigphp/Twig/pull/1753), so this basically undoes most of #439 to use the base class instead.

emodric commented 7 years ago

Ping @gnat42