schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Fix PHP Notice: "Array to string conversion" #445

Closed snpy closed 7 years ago

snpy commented 7 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? untested case?
Fixed tickets hotfix
License Apache2

Description

Configuration validation was throwing Symfony\Component\Debug\Exception\ContextErrorException caused by:

Notice: Array to string conversion in /Users/marek/workspace/gg/website/vendor/jms/translation-bundle/JMS/TranslationBundle/DependencyInjection/Configuration.php:84

in case provided provided dir is prefixed with not existing bundle.

Wrapping array_keys with implode(', ', ...) fixes the issue.

Todos

gnat42 commented 7 years ago

Thanks a bunch and nice catch!

snpy commented 7 years ago

Thanks for quick merge :)