search

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Fixed twig node visitor signature #449

Closed deguif closed 7 years ago

deguif commented 7 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Description

Previous PR by @emodric added the Twig 2.0 compatibility by extending the \Twig_BaseNodeVisitor on twig visitor nodes. But the methods doEnterNode and doLeaveNode are declared protected on inherited class.

This PR declare these methods as protected as they should be. I flagged this as BC break because of this, but not sure if it's relevant in this case.

emodric commented 7 years ago

Whoops, overlooked that one!

Thanks for correcting me @deguif :)

emodric commented 7 years ago

BTW, since my change renaming enterNode to doEnterNode and leaveNode to doLeaveNode (#441) is not tagged yet, your PR is not a BC break.

deguif commented 7 years ago

Just updated the PR description so that it's not marked anymore as a BC break