search

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Fix nikic/php-parser v4 compatibility #490

Closed soullivaneuh closed 6 years ago

soullivaneuh commented 6 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License Apache2

Closes #485 Closes #476

Description

477 introduces some bug with nikic/php-parser v4.

I fixed most of them, but I'm currently stuck for the form extractor.

The issue seems to be the Class_ node statement does not have anything more on it implements property, and the interface implement detection does not work: https://github.com/schmittjoh/JMSTranslationBundle/blob/master/Translation/Extractor/File/TranslationContainerExtractor.php#L99-L109

I can't figure out why for now, help would be appreciated.

I also let the PR editable for the maintainers. :+1:

Todos

soullivaneuh commented 6 years ago

Oh I missread by dumps, the implements property does has something. I'm on it.

soullivaneuh commented 6 years ago

I finally manage it! :tada:

All the tests work like before now.

soullivaneuh commented 6 years ago

May we have a new release after this fix? :-)

gnat42 commented 6 years ago

Thanks a lot for your contribution. Release coming soon.