search

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Remove deprecated usage of TreeBuilder on Symfony 4 #513

Closed emodric closed 5 years ago

emodric commented 5 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License Apache2

Supports usage of TreeBuilder in Symfony 4.2+.

Todos

goetas commented 5 years ago

Hi, all the tests are failing with Undefined property: JMS\TranslationBundle\DependencyInjection\Configuration::$rootNodeName

emodric commented 5 years ago

Whoops, sorry about that! Fixed now!

goetas commented 5 years ago

looks good. test failures are not related to this.

goetas commented 5 years ago

thanks