search

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Compile nodes before comparing them #518

Closed greg0ire closed 4 years ago

greg0ire commented 4 years ago
Q A
Bug fix? not for the end user
New feature? no
BC breaks? no, only tests changes
Deprecations? no
Tests pass? yes, that's the whole point
Fixed tickets
License Apache2

Description

Not sure since when, but parsing is not enough to obtain the same code from different fixtures. Adding that extra step fixes the failing tests and the build.

greg0ire commented 4 years ago

At least one of the jobs is failing :man_facepalming: … and the error message is not helpful at all, not sure what to do.

EDIT: oh wait, it actually contains something helpful: /home/travis/build/schmittjoh/JMSTranslationBundle/Tests/Functional/Fixture/TestBundle/Resources/translations/navigation.en.yml

greg0ire commented 4 years ago

Note that many of the jobs are green though, so maybe this can be merged as is? I mean it's an improvement for sure…

goetas commented 4 years ago

Thanks @greg0ire