search

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Replace kernel.root_dir with kernel.project_dir #522

Closed franmomu closed 4 years ago

franmomu commented 4 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License Apache2

Description

kernel.root_dir was deprecated in Symfony 4.2 and is removed in 5.0. This PR tries to replace kernel.root_dir by kernel.project_dir wherever is possible and do not use kernel.root_dir if is not defined. I also changed the docs to reference the translations folder at the root directory of the project (which is the recommended place).

After this one (and https://github.com/schmittjoh/JMSTranslationBundle/pull/523), I think the only left to do to be able to use SF5 are commands, I'll take a look then.

goetas commented 4 years ago

can you please rebase this?

goetas commented 4 years ago

thanks!

greg0ire commented 4 years ago

@goetas can you please tag a new release with this?

goetas commented 4 years ago

Will prepare it in the next days.

@franmomu is there something that you have still planned to do? What do you think about?

franmomu commented 4 years ago

Will prepare it in the next days.

@franmomu is there something that you have still planned to do? What do you think about?

I don't have anything more planned to do, I think it's ready to tag a new release.

goetas commented 4 years ago

Ok, then I have it on my todo list. Will have to go throughout the changes and see if a feature release is safe enough.

(I hope so),... The last feature release was years ago