schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Add Doctrine Coding Standards in tests #525

Closed franmomu closed 4 years ago

franmomu commented 4 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License Apache2

Description

I basically copied more or less the structure of Travis and PHPCS from https://github.com/schmittjoh/serializer.

I added doctrine/coding-standard package and I also only added Tests folder to check the CS. After getting this working, I'll add another PR fixing the rest of the code.

This is going to fail as it needs to execute phpcbf and fix some tests, but that would be after https://github.com/schmittjoh/JMSTranslationBundle/pull/523.

TODO

goetas commented 4 years ago

hmm, the github merge broke something... can you please take care of ?

goetas commented 4 years ago

huge thanks!