schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Fix calls passing the right scalar type #526

Closed franmomu closed 4 years ago

franmomu commented 4 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License Apache2

Description

In order to be able to use declare(strict_types=1), I've changed some functions that require an specific type. The changes are:

goetas commented 4 years ago

can you check the test failure?

franmomu commented 4 years ago

can you check the test failure?

Apparently some tests were failing intermittently. It was always about not finding one file that it is created and removed in another test. So I changed the configuration for that test to write that file in another directory, not sure if it was the problem, but now they pass.

You can try to re-run the tests a couple of time to see if it works.

goetas commented 4 years ago

Thanks