schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids

http://jmsyst.com/bundles/JMSTranslationBundle

426 stars 292 forks source link

Closed franmomu closed 4 years ago

franmomu commented 4 years ago

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	not yet
Fixed tickets	https://github.com/schmittjoh/JMSTranslationBundle/issues/517 and https://github.com/schmittjoh/JMSTranslationBundle/issues/516
License	Apache2

Description

Trying to make the bundle compatible with Symfony 5 and Twig 3

goetas commented 4 years ago

uuuuu! this is nice! looking forward to it!

franmomu commented 4 years ago

Apparently when https://github.com/schmittjoh/JMSTranslationBundle/pull/529 gets merged, it would only need to add return int type to the execute method of the commands, and that's it 😬

goetas commented 4 years ago

franmomu commented 4 years ago

I removed the use in tests of transchoice when using Symfony 5 since it was removed.

goetas commented 4 years ago

I'm pretty happy with the result, let me know if you are done so I can merge it :)

franmomu commented 4 years ago

I'm pretty happy with the result, let me know if you are done so I can merge it :)

I think it's fine!

goetas commented 4 years ago

Thanks and excellent work lately!