Do not depend in previous libxml state

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids

http://jmsyst.com/bundles/JMSTranslationBundle

427 stars 291 forks source link

Do not depend in previous libxml state #543

Closed goetas closed 4 years ago

goetas commented 4 years ago

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	https://github.com/schmittjoh/JMSTranslationBundle/issues/542
License	Apache2

drola commented 4 years ago

Hi, it should be actually like this:

libxml_disable_entity_loader(false);

instead of

libxml_disable_entity_loader(true);

It would also be nice to have a test for the behavior of both flags in this section of the code. Thank you for this contribution. Also thanks for refactoring the variable names.