schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
427 stars 291 forks source link

Add the option to dump files to the ICU message format #551

Closed mark-gerarts closed 3 years ago

mark-gerarts commented 3 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #550
License Apache2

Description

As mentioned in #550: this commit adds the options to dump files in the ICU message format. This means the file gets suffixed with +intl-icu, e.g.: messages+intl-icu.en.yaml.

Some general remarks:

So, happy to hear your feedback!

mark-gerarts commented 3 years ago

Hmm, the CI fails because of an unrelated composer 2 issue?

Root composer.json requires doctrine/coding-standard ^7.0 -> satisfiable by doctrine/coding-standard[7.0.0, 7.0.1, 7.0.2].

goetas commented 3 years ago

thanks for your contribution, indeed we should use composer v1.x to avoid the CI failure