Closed mark-gerarts closed 3 years ago
Hmm, the CI fails because of an unrelated composer 2 issue?
Root composer.json requires doctrine/coding-standard ^7.0 -> satisfiable by doctrine/coding-standard[7.0.0, 7.0.1, 7.0.2].
thanks for your contribution, indeed we should use composer v1.x to avoid the CI failure
Description
As mentioned in #550: this commit adds the options to dump files in the ICU message format. This means the file gets suffixed with
+intl-icu
, e.g.:messages+intl-icu.en.yaml
.Some general remarks:
--intl-icu
commandline,intl_icu
in the config)messages.nl.xliff
as well asmessages+intl-icu.nl.xliff
. There is no indication which file you're editing, and no option to switch. It still works though, so I see this more as a thing for a future PR.FileUtils
: I took the liberty to use named capturing groups, because with another group added things were getting confusing.FileUtils
, but wanted to get this PR out first in order to get some feedback.So, happy to hear your feedback!