Fix --intl-icu option - Githubissues

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids

http://jmsyst.com/bundles/JMSTranslationBundle

427 stars 291 forks source link

Fix --intl-icu option #561

Closed adriendupuis closed 1 year ago

adriendupuis commented 3 years ago

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	yes
Deprecations?	no
Tests pass?	yes/no
Fixed tickets	N/A
License	Apache2

Description

--intl-icu option was never interpreted because of a misuse of InputInterface::hasParameterOption. ICU message format couldn't be used.

There could be a BC break for users who have leave an --intl-icu option while using a workaround like a domain name directly suffixed with +intl-icu.

Todos

[ ] Tests
[ ] Documentation
[ ] Changelog

balbinus commented 2 years ago

I upvote this ^^

deguif commented 1 year ago

@goetas this one should also be ready for merge, if you have time to review it?