search

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
427 stars 291 forks source link

Handle properly promoted constructor properties default values #574

Closed deguif closed 1 year ago

deguif commented 1 year ago
Q A
Bug fix? yes
New feature? yes/no
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets
License Apache2

Description

When using constructor promoted properties on constraints, the validation extractor fails with this error:

In ValidationExtractor.php line 181:

  Warning: Undefined array key "message"

This PR is about to handle default value when using promoted properties.

goetas commented 1 year ago

thank you!

deguif commented 1 year ago

@goetas could you merge the 1.x in master, as it's not included on master.

goetas commented 1 year ago

https://github.com/schmittjoh/JMSTranslationBundle/releases/tag/1.9.0

deguif commented 1 year ago

Yes, thank you for the release. I'm using the master as there is support for symfony 6.x inside, but this fix is not inside ;)