search

schmittjoh / JMSTranslationBundle

Puts the Symfony2 Translation Component on steroids
http://jmsyst.com/bundles/JMSTranslationBundle
426 stars 292 forks source link

Fix deprecations triggered since twig 3.12.0 #591

Closed deguif closed 3 weeks ago

deguif commented 1 month ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets
License Apache2

Description

Avoid deprecations triggered by twig 3.12 while keeping backward compatibility

Here's the deprecations it fixes:

Since twig/twig 3.12: Getting node "filter" on a "Twig\Node\Expression\FilterExpression" class is deprecated.
Since twig/twig 3.12: Getting node "filter" on a "Twig\Node\Expression\Filter\RawFilter" class is deprecated.
deguif commented 1 month ago

@goetas do you think it can be merged soon?

deguif commented 3 weeks ago

Friendly ping @goetas , as we are waiting for this before upgrading twig to 3.12 and later.

goetas commented 3 weeks ago

Sorry for the delay

deguif commented 3 weeks ago

Thanks @goetas