Disabling accessor setter when value resolution falls back to the property default value

schmittjoh / serializer

Library for (de-)serializing data of any complexity (supports JSON, and XML)

http://jmsyst.com/libs/serializer

MIT License

2.32k stars 585 forks source link

Disabling accessor setter when value resolution falls back to the property default value #1422

Closed joaojacome closed 1 year ago

joaojacome commented 2 years ago

Q	A
Bug fix?	yes
New feature?	no
Doc updated	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#1421
License	MIT

joaojacome commented 2 years ago

@goetas @scyzoryck please review :)

joaojacome commented 2 years ago

Hello :)

So, the previous MR fixing the default value for constructors had a BC, and this MR is to fix that. BUT, this ~could~ be considered a BC regarding the last version.

joaojacome commented 1 year ago

@goetas Can you take a look at this one?

Thanks!

goetas commented 1 year ago

@joaojacome hi, I will! sorry for the delay

annervisser commented 1 year ago

@goetas any chance you could tag a release? We are currently unable to upgrade beyond 3.17.1 and this PR fixes that