search

schmittjoh / serializer

Library for (de-)serializing data of any complexity (supports JSON, and XML)
http://jmsyst.com/libs/serializer
MIT License
2.32k stars 585 forks source link

Allow doctrine/annotations 2.0 #1451

Closed mbabker closed 1 year ago

mbabker commented 1 year ago
Q A
Bug fix? no
New feature? yes
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT

This will allow using the doctrine/annotations package's 2.x release with the serializer. The only B/C issue in https://github.com/doctrine/annotations/blob/2.0.x/UPGRADE.md that looks to impact this package was already addressed by #1447 so there shouldn't be any other problems.

scyzoryck commented 1 year ago

Thanks for contribution! Looking at the tests that are running I see something is still blocking this package to be installed even on PHP8.2 🤔 https://github.com/schmittjoh/serializer/actions/runs/3824447038/jobs/6506598849

Cache restored from key: linux-php-8.2.0-highest-f81472160faeef1eaa5801fd054d11c93d351ed53ad42a7eaac0d3147b228a45---ignore-platform-req=php
Info from [https://repo.packagist.org:](https://repo.packagist.org/) #StandWithUkraine
Updating dependencies
Lock file operations: 96 installs, 0 updates, 0 removals
  - Locking dealerdirect/phpcodesniffer-composer-installer (v0.7.2)
  - Locking doctrine/annotations (1.14.2)
mbabker commented 1 year ago

It's probably https://github.com/doctrine/phpcr-odm/pull/834 blocking it just on a quick scan over the dependency list.

mbabker commented 1 year ago

The bootstrap's updated.

msteltenpool commented 1 year ago

Could a new release/tag be made?

goetas commented 1 year ago

https://github.com/schmittjoh/serializer/releases/tag/3.19.0