feat(doctrine): Parse Doctrine Enums types

schmittjoh / serializer

Library for (de-)serializing data of any complexity (supports JSON, and XML)

http://jmsyst.com/libs/serializer

MIT License

2.32k stars 589 forks source link

Closed scyzoryck closed 1 year ago

scyzoryck commented 1 year ago

Q	A
Bug fix?	no
New feature?	yes
Doc updated	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	https://github.com/schmittjoh/serializer/issues/1461, https://github.com/schmittjoh/JMSSerializerBundle/issues/918
License	MIT

In ORM 2.11 Doctrine introduced Enum support. Serializer still parses it as integer or string, what is causing errors.

[x] As it will require EnumHandler to work properly, should we enable it by default for PHP 8.1? I think BC impact would be minimal as I hope enum is not popular FQCN for class in 2023.

scyzoryck commented 1 year ago

With latest changes:

Doctrine is resolving enums mapped to string or int in DB to FQCN.
EnumPropertiesDriver do not duplicates responsibilities from TypedPropertiesDriver - it works on top of others by overriding Enum FQCN to enum<FQCN>. It should cover also cases from: https://github.com/schmittjoh/serializer/pull/1458