search

schmittjoh / serializer

Library for (de-)serializing data of any complexity (supports JSON, and XML)
http://jmsyst.com/libs/serializer
MIT License
2.32k stars 586 forks source link

JMS serializer implements Symfony serializer #1484

Closed themark147 closed 1 year ago

themark147 commented 1 year ago

Hello,

In SF 6.3 we will have feature https://symfony.com/blog/new-in-symfony-6-3-mapping-request-data-to-typed-objects

but RequestPayloadValueResolver resolver requires Only interfaces from symfony serializer ... its any change JMS serializer will be implements symfony serializer interface? cause JMS is used by JMS bundle and FOS rest bundle

thanks

scyzoryck commented 1 year ago

Hi! Thanks for sharing! It looks like an interesting feature, however adding dependency on interface from symfony to this package directly might be not the best idea. Strong coupling will introduce more breaking changes, not needed for most of the projects. I think we might think about some kind of adapter that will make it work with symfony inside JMS bundle package. But I am open for other ideas too.

Best, scyzoryck.

themark147 commented 1 year ago

yea u right I should start discuss about that feature in JMS Bundle sorry. Also agree with coupling. I will try to think about it how it can be done with some adapter right in bundle

Thanks!

scyzoryck commented 1 year ago

No problem! Feel free to submit pull request. I will be glad to help with code review or the merge process.

Best scyzoryck.

scyzoryck commented 1 year ago

Let's move discussion to: https://github.com/schmittjoh/JMSSerializerBundle/issues/928