Closed dgafka closed 1 year ago
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
Doc updated | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
License | MIT |
Thanks for contribution!
I wonder what is a blocker to install it. In the past it was doctrine/orm
, doctrine/odm
but I think both already got support for instantiator 2.0 🤔
https://github.com/schmittjoh/serializer/actions/runs/5112376250/jobs/9190336016?pr=1488
As in general it would be great to have running tests with it before merge :D
I wonder what is a blocker to install it.
https://github.com/doctrine/phpcr-odm/pull/844 was only merged to the 2.0 branch. It just got a beta tag last week. So unless that gets backported, there'd be no way of installing doctrine/instantiator
2.x alongside any doctrine/phpcr-odm
1.x release.
Ahm! True - I got lost in odm versions :D
Tested locally with odm 2.0-dev and instantiator 2.0.0
. All looks good, tests are passing.
Thanks Marcin :)