search

schmittjoh / serializer

Library for (de-)serializing data of any complexity (supports JSON, and XML)
http://jmsyst.com/libs/serializer
MIT License
2.32k stars 589 forks source link

Allow doctrine instantiator 2.0 #1488

Closed dgafka closed 1 year ago

dgafka commented 1 year ago
Q A
Bug fix? no
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT
dgafka commented 1 year ago

Doctrine instantiator was bumped to 2.0, in order to use PHP 8.1 features, so there are no B/C.

scyzoryck commented 1 year ago

Thanks for contribution!

I wonder what is a blocker to install it. In the past it was doctrine/orm, doctrine/odm but I think both already got support for instantiator 2.0 🤔 https://github.com/schmittjoh/serializer/actions/runs/5112376250/jobs/9190336016?pr=1488 As in general it would be great to have running tests with it before merge :D

mbabker commented 1 year ago

I wonder what is a blocker to install it.

https://github.com/doctrine/phpcr-odm/pull/844 was only merged to the 2.0 branch. It just got a beta tag last week. So unless that gets backported, there'd be no way of installing doctrine/instantiator 2.x alongside any doctrine/phpcr-odm 1.x release.

scyzoryck commented 1 year ago

Ahm! True - I got lost in odm versions :D

Tested locally with odm 2.0-dev and instantiator 2.0.0. All looks good, tests are passing.

dgafka commented 1 year ago

Thanks Marcin :)