Closed ruudk closed 1 year ago
The code looks good - I wonder if the dropping the support for
doctrine/lexer
might be a breaking changes.
It should be fine. The ORM dropped Lexer 1.x support in 2.15.0, and everything but this package in the main app I work in now requires at least 2.0. So in practice, it's already getting to a point where Lexer 1.0 isn't installable with current dependencies.
Can we merge and tag it please? 💙
Can you please rebase the pull request?
@goetas done
@goetas Could you merge and tag this? Scrutinizer is not really working properly. 🙏
By requiring
doctrine/lexer
v2 we can solve the following deprecation: