search

schmittjoh / serializer

Library for (de-)serializing data of any complexity (supports JSON, and XML)
http://jmsyst.com/libs/serializer
MIT License
2.32k stars 589 forks source link

Require Doctrine Lexer v2 and stop accessing Token properties via ArrayAccess to stop deprecation #1491

Closed ruudk closed 1 year ago

ruudk commented 1 year ago
Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

By requiring doctrine/lexer v2 we can solve the following deprecation:

Accessing Doctrine\Common\Lexer\Token properties via ArrayAccess is deprecated, use the value, type or position property instead (Token.php:104 called by Parser.php:46, https://github.com/doctrine/lexer/pull/79, package doctrine/lexer)
mbabker commented 1 year ago

The code looks good - I wonder if the dropping the support for doctrine/lexer might be a breaking changes.

It should be fine. The ORM dropped Lexer 1.x support in 2.15.0, and everything but this package in the main app I work in now requires at least 2.0. So in practice, it's already getting to a point where Lexer 1.0 isn't installable with current dependencies.

ruudk commented 1 year ago

Can we merge and tag it please? 💙

goetas commented 1 year ago

Can you please rebase the pull request?

ruudk commented 1 year ago

@goetas done

ruudk commented 1 year ago

@goetas Could you merge and tag this? Scrutinizer is not really working properly. 🙏