chore(composer): Update doctrine code standards to 12.x

schmittjoh / serializer

Library for (de-)serializing data of any complexity (supports JSON, and XML)

http://jmsyst.com/libs/serializer

MIT License

2.32k stars 588 forks source link

chore(composer): Update doctrine code standards to 12.x #1503

Closed scyzoryck closed 1 year ago

scyzoryck commented 1 year ago

Q	A
Bug fix?	no
New feature?	no
Doc updated	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT

Let's go one more step in compare to: https://github.com/schmittjoh/serializer/pull/1305 Newest version is 12, but with 10 it started to require one line comments :) Do we also want to go that way?

scyzoryck commented 1 year ago

Merging to unblock @mbabker work :)

scyzoryck commented 1 year ago

I will take a look at the failing master pipeline later today & provide the fixes. :(

mbabker commented 1 year ago

The one fail is related to the ORM 2.16 release, https://github.com/doctrine/orm/issues/10864 if you're interested in why it's seemingly a bigger issue for other projects (here it just messes up the JSON string comparison).

The errors are because in rebasing #1494 I managed to change a FQCN reference for the annotation to a short name without a use statement, oops.