schmittjoh / serializer

Library for (de-)serializing data of any complexity (supports JSON, and XML)
http://jmsyst.com/libs/serializer
MIT License
2.31k stars 591 forks source link

Require PHP 7.4 and Symfony 5.4 #1528

Closed mbabker closed 7 months ago

mbabker commented 7 months ago
Q A
Bug fix? no
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT

Similar to https://github.com/schmittjoh/JMSSerializerBundle/pull/937, this proposes bumping the minimum library requirements to PHP 7.4 and Symfony 5.4. Older Symfony versions are no longer supported, and the Packagist stats show only ~3% of recent 3.x downloads are on PHP 7.2 and 7.3.

scyzoryck commented 7 months ago

Looks good for me! @goetas - do you think it should be released under 3.x or under new major version?

goetas commented 7 months ago

increasing the min required version it is not a BC break, it can be done in a feature release, no major required