search

schmittjoh / serializer

Library for (de-)serializing data of any complexity (supports JSON, and XML)
http://jmsyst.com/libs/serializer
MIT License
2.32k stars 588 forks source link

Fix serialization of BackedEnum - annotation without name/value #1536

Closed iKsSs closed 7 months ago

iKsSs commented 8 months ago
Q A
Bug fix? yes
New feature? no
Doc updated yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

Serialization of Backed Enum, when property has Serializer annotation with specified Enum Class but second parameter (name/value), is not provided was not behaving according to documentation.

scyzoryck commented 8 months ago

@goetas could you help with review, please? :)

goetas commented 7 months ago

Looks good to me. I'm surprised that i forgot to implement it from get go.

i have left only one minor comment