search

schmitzal / tinyimg

TYPO3-Extension which compresses images (png & jpg) uploaded in the backend with the tinypng API
GNU General Public License v3.0
15 stars 11 forks source link

Cronjob PHP Warning #32

Closed bm1-phillip closed 5 years ago

bm1-phillip commented 6 years ago

Ich bekomme beim ausführen diese Fehlermeldung:

Die Ausführung von Task "Extbase-CommandController-Task (extbase)" ist fehlgeschlagen mit folgender Meldung: PHP Warning: explode() expects parameter 2 to be string, object given in /html/typo3/typo3_src-8.7.19/typo3/sysext/core/Classes/Utility/GeneralUtility.php line 1302

schmitzal commented 5 years ago

Would you mind trying to get the stack trace to know at which point the error is thrown?

bm1-phillip commented 5 years ago

Would you mind trying to get the stack trace to know at which point the error is thrown?

Sorry, I'm not a developer, so I do not know how to do that. With a detailed guide, I would possibly do it. Altervativ I can also give you access to the TYPO3.

schmitzal commented 5 years ago

Access to the TYPO3 would help. Are you in the TYPO3 Slack? You could write me there a DM with a temporary admin user.

bm1-phillip commented 5 years ago

Are you in the TYPO3 Slack? You could write me there a DM with a temporary admin user.

Yes I have, message is out now.

jonasesr commented 5 years ago

Is there a solution by now? The proglem is, that you call
$folder = $this->resourceFactory->getFolderObjectFromCombinedIdentifier($file->getParentFolder()); in line 73 of /tinyimg/Classes/Command/CompressImagesCommandController.php. The required argument is a string that looks like this 1:/user_upload/ but it gets a folder object that can't be exploded.

schmitzal commented 5 years ago

Hello Chegaro,

thanks a lot for your merge request. I'll have a look at it, as soon as possible.

Edit: This issue will be fixed in the next release, as I'm removing the whole folder dependency in both Command and Service. I still have to do a few tests with Amazon CDN as this wasn't working with the change and setting up a testing environment is a bit tricky. See #27

Edit 2: Meanwhile you could load version dev-develop if you don't use Amazon CDN, which now comes with this bugfix.

bm1-phillip commented 5 years ago

I tried the dev version. The following error message appears:

Warning: Uncaught TYPO3\CMS\Core\Error\Exception: PHP Warning: require_once(/html/typo3/typo3conf/ext/tinyimg/Classes/Service/../../vendor/autoload.php): failed to open stream: No such file or directory in /html/typo3/typo3conf/ext/tinyimg/Classes/Service/CompressImageService.php line 15 in /html/typo3/typo3_src-8.7.20/typo3/sysext/core/Classes/Error/ErrorHandler.php:107 Stack trace: #0 /html/typo3/typo3conf/ext/tinyimg/Classes/Service/CompressImageService.php(15): TYPO3\CMS\Core\Error\ErrorHandler->handleError(2, 'require_once(/h...', '/html/typo3/typ...', 15, Array) #1 /html/typo3/typo3conf/ext/tinyimg/Classes/Service/CompressImageService.php(15): require_once() #2 /html/typo3/typo3_src-8.7.20/vendor/composer/ClassLoader.php(444): include('/html/typo3/typ...') #3 /html/typo3/typo3_src-8.7.20/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/home/www/p4150...') #4 /html/typo3/typo3_src-8.7.20/vendor/typo3/class-alias-loader/src/ClassAliasLoader.php(130): Composer\Autoload\ClassLoader->loadClass('S in /html/typo3/typo3_src-8.7.20/typo3/sysext/core/Classes/Error/ErrorHandler.php on line 107

Fatal error: main(): Failed opening required '/html/typo3/typo3conf/ext/tinyimg/Classes/Service/../../vendor/autoload.php' (include_path='.:') in /html/typo3/typo3conf/ext/tinyimg/Classes/Service/CompressImageService.php on line 15

schmitzal commented 5 years ago

Was the close a missclick or is the problem solved?

So you are running a Composer based setup right?

bm1-phillip commented 5 years ago

The problem based on commit #33 The mistake comes when I execute the cron extbase tinyimg compress.

schmitzal commented 5 years ago

Did you update via composer or just downloaded and replaced it on the server?

schmitzal commented 5 years ago

I have updated the develop branch. Running tinyimg on a composer based setup works now like a charm for me. I'll test it with a non composer setup tomorrow and if positiv release the new version with it fixes and TYPO3 9.5 support.

schmitzal commented 5 years ago

Version 1.3.0 is released now. Support for non composer setup has been dropped. Developers have to take care of installing the tinify library themself if the extension is installed via the extension manager.