search

schmod / babel-plugin-angularjs-annotate

Add Angular 1.x dependency injection annotations to ES6 code
http://schmod.github.io/babel-plugin-angularjs-annotate
MIT License
241 stars 26 forks source link

Remove ngInject directives from transformed source #39

Closed bhollis closed 4 years ago

bhollis commented 6 years ago

This implements #38 by removing "ngInject" prologue directives while we process. In accordance with https://github.com/schmod/babel-plugin-angularjs-annotate/issues/38#issuecomment-357706985, which asks that multiple passes through the transform and minifier still work, I didn't remove "ngNoInject" directives, since they are there to prevent the automatic annotation. Multiple runs through minifiers should be OK, since the $inject has already been generated and won't be further minified.

schmod commented 6 years ago

Thanks for the PR. I'll try to take a look at this tonight!

bhollis commented 6 years ago

I know you've been super busy, but I wanted to get this back on your radar - my hope is that this is simple enough.

bhollis commented 5 years ago

Anything I can do here?