search

schmorrison / Zoho

Golang API for Zoho services
MIT License
35 stars 34 forks source link

Recruit - initial commit #41

Closed Bibi40k closed 2 years ago

schmorrison commented 2 years ago

Why closed?

Bibi40k commented 2 years ago

Who closed it ? It's my first pull request ever, if it's on me, it was 100% by mistake.

schmorrison commented 2 years ago

Reopened!

Bibi40k commented 2 years ago

I have made another mistake :( i have deleted Bibi40k:recruit ... i didn't know where it came from. I thought i uploaded changes to my repo instead here, to yours. How can i fix this, should i open another PR ?

schmorrison commented 2 years ago

I have made another mistake :( i have deleted Bibi40k:recruit ... i didn't know where it came from. I thought i uploaded changes to my repo instead here, to yours. How can i fix this, should i open another PR ?

Im honestly not sure what to do in that case. Presumably the fork/branch still exists somewhere cause the PR still exists. I wonder if you refork and push the code to that repo (same name as old repo), maybe Github is smart enough to figure it out. I imagine my review will be made "outdated" though.

You might have to do some Googleing on this one unfortunately.

Bibi40k commented 2 years ago

Can i delete PR and start it over ? I already have fixed what you suggested

Bibi

On 2 May 2022, at 17:22, Sam Morrison @.***> wrote:

I have made another mistake :( i have deleted Bibi40k:recruit https://github.com/Bibi40k/Zoho/tree/recruit ... i didn't know where it came from. I thought i uploaded changes to my repo instead here, to yours. How can i fix this, should i open another PR ?

Im honestly not sure what to do in that case. Presumably the fork/branch still exists somewhere cause the PR still exists. I wonder if you refork and push the code to that repo (same name as old repo), maybe Github is smart enough to figure it out. I imagine my review will be made "outdated" though.

You might have to do some Googleing on this one unfortunately.

— Reply to this email directly, view it on GitHub https://github.com/schmorrison/Zoho/pull/41#issuecomment-1114954684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7KDIIG655V5JDTIXI7K4DVH7QLJANCNFSM5UV2467A. You are receiving this because you authored the thread.

schmorrison commented 2 years ago

Sure, push new changes to new PR. We will keep this opened for reference until all the comments are resolved.

Bibi40k commented 2 years ago

create new PR