search

schmorrison / Zoho

Golang API for Zoho services
MIT License
35 stars 34 forks source link

Add support for zoho expense api #7

Closed ashishsnigam closed 5 years ago

ashishsnigam commented 5 years ago

First draft towards adding support of Zoho expense API. 1) Added expense API list_all_expenses to list all expenses report for a given organization id 2) Added expense API GetOrganization to get organization_id to be passed in all expense api 3) Updated zoho struct to have additional field for organization id 4) Added method SetOrganizationId to update zoho struct to have additional field for organization id 5) Added new scopes for expense api 6) Fix variable assignment issue in existing code

schmorrison commented 5 years ago

Thanks for the PR!! I will review in the morning.

ashishsnigam commented 5 years ago

@schmorrison ,

I have incorporated your review comments. Also agreed with you on moving Scopes, Settings methods as you suggested. In addition, I can help you in putting more APIs there. Just find out the most used or requested ones and I will try to incorporate them also.

Thanks, Ashish

schmorrison commented 5 years ago

Awesome, thanks for your contribution @ashishsnigam.