search

schmorrison / Zoho

Golang API for Zoho services
MIT License
35 stars 34 forks source link

Requests: API to implement #8

Open schmorrison opened 5 years ago

schmorrison commented 5 years ago

Leave a comment in this issue if you would like to see an API, or specific function of an API implemented.

bondar-pavel commented 3 years ago

Hello, thanks for your work. We already using Zoho CRM in our projects.

And also would like to see Zoho Subscriptions API. More specifically currently we would like to manage Subscriptions&Invoices: https://www.zoho.com/subscriptions/api/v1/#Subscriptions https://www.zoho.com/subscriptions/api/v1/#Invoices

schmorrison commented 3 years ago

@bondar-pavel noted. I will see what I can do about that. Looking over the API docs there shouldn't be any surprises. Feel free to have a run at it, submit a PR, and I can make changes where necessary. Otherwise, it has been added to the roadmap.

BTW, thanks for the endorsement. :)

bondar-pavel commented 3 years ago

Added draft pull request with List and Get Subscription for now: https://github.com/schmorrison/Zoho/pull/25

ysahil97 commented 3 years ago

Hello, I appreciate your work in building this comprehensive Zoho go API library

I have been working in a startup which uses golang. We wanted to have Zoho bookings (link) implementation to be used for our purpose. Currently I have forked your repo and written the Zoho booking API implementations. Could I submit a PR for the same?

schmorrison commented 3 years ago

Absolutely @ysahil97 !!

It always take a few days for me to review be warned. :)

ashishsnigam commented 3 years ago

@schmorrison I can again contribute to this repo. Please feel free to assign me any task. I will do it in my free time.

schmorrison commented 3 years ago

I'll get some kind of a roadmap together. Lots of little features I'd like to add but just don't have enough time. I'd love the help.

I think implementing endpoints can be a little boring, so the big goal is to make contribution as simple as possible.

To that end, here are a couple ideas:

I started work many months ago on a code generation branch. Not sure if it's a totally appropriate approach though.

More recently I started working on a branch to add unit tests, something I am very unfamiliar with. I figure it'd be great if users could contribute a unit test along with their endpoint contribution. Setting up a way to test the endpoint would be amazing. A mock HTTP server/client and inspect the requests/responses, (requests to Zoho shouldn't be performed during tests I figure).

Finally, Zoho has custom fields. I'd like to figure out how we might be able to use struct embedding to encode/decode custom fields along with the standard fields.

Start an issue if you want to take anything on, we can discuss the details there.

Again, thanks for the offer!!

ashishsnigam commented 3 years ago

Hi @schmorrison Zoho officially does not support Golang based SDKs. May be we can start working towards that direction taking inspiration from Python SDK and make this repo as unofficial Golang SDK for Zoho.

Regarding unit tests, for new apis unit tests should be written along with API wrapper. And for already developed apis it's a work to be completed. I propose, you should first create TODO tasks in this repo itself. Refactoring will always be there as and when needed.

schmorrison commented 3 years ago

@ashishsnigam Ok, great.

I think if we build something good, that regard will follow. I'll work on a todo list and publish it to the repo, can I send you an email directly?

ashishsnigam commented 3 years ago

@schmorrison sure.

schmorrison commented 3 years ago

@ashishsnigam checkout issue #33