search

schnaader / fairytale

encode.ru community archiver
GNU Lesser General Public License v3.0
31 stars 13 forks source link

Unicode file name #11

Open tuyethoa08041997 opened 6 years ago

tuyethoa08041997 commented 6 years ago

Look like this FileStream can't handle a Unicode file name. Is that true?

https://github.com/schnaader/fairytale/blob/3bdb3f978e8f5a74ca8034a6cacdc808343d0146/filestream.h#L32

(Sorry if my English is bad, I'm not a native speaker)

jagannatharjun commented 6 years ago

if we can push c++ standard to c++17 then we can use filesystem::path

M-Gonzalo commented 6 years ago

if we can push c++ standard to c++17 then we can use filesystem::path

Can we? What is needed?

jagannatharjun commented 6 years ago

it's more like if @schnaader @MarcioPais agrees..

tuyethoa08041997 commented 6 years ago

currently filesystem::path is experimental, i don't know if that should be considered.

jagannatharjun commented 6 years ago

it's merged into c++17 in last meeting and now part of c++17 standards, and msvc,gcc8 fully implements it,