search

schnaader / fairytale

encode.ru community archiver
GNU Lesser General Public License v3.0
31 stars 13 forks source link

Applied clang-format #20

Closed andrew-epstein closed 6 years ago

andrew-epstein commented 6 years ago

I used unformat to generate a .clang-format file that most closely matches the existing formatting, and then applied that formatting to all code in the repo. If a different style is preferred, that's fine, but hopefully we can agree on something and then keep it consistent going forward.

schnaader commented 6 years ago

@andrew-epstein : I merged master into this PR. You could have a look if all the zlib files in the contrib folder are OK or apply reformatting if not.

schnaader commented 6 years ago

The PR looks good for me, unfortunately, the Visual Studio ClangFormat extension doesn't seem to work with my VS 2015, so I'll have to try some alternatives - Visual Studio code has an extension that looks promising - and if this doesn't work, I'll switch to VS 2017 or just install LLVM and try using clang-format from command line

andrew-epstein commented 6 years ago

Looking at this formatting, the one thing I don't like is the lack of indentation for preprocessor directives. Let me make a quick change to the .clang-format file and reformat.