search

schnatterer / musicbrainzws2-java

java binding for MusicBrainz XML Web Service/Version 2
GNU General Public License v3.0
15 stars 10 forks source link

Replace String tag with proprietary object to store their vote #7

Open dukeyin opened 2 years ago

dukeyin commented 2 years ago

Currently, TagList is List: https://github.com/schnatterer/musicbrainzws2-java/blob/f280b10179073afb2dcd7845cd4bd1818593e60a/src/main/java/org/musicbrainz/query/submission/EntityElement.java#L34

Instead of String, each Tag should really be an object with both a name and a vote (upvote, downvote, withdraw), which enables the user to submit modifications to their tags rather than a complete replacement: https://musicbrainz.org/doc/MusicBrainz_API#tags

dukeyin commented 2 years ago

(nevermind, was using UserRatingSubmissionWs2 instead of UserTagSubmissionWs2)