plantuml: make server build time configurable

schnatterer / smeagol-galore

A git-based wiki featuring markdown, a WYSIWYG Editor, PlantUML, and much more

MIT License

24 stars 5 forks source link

plantuml: make server build time configurable #1

Closed silvio closed 6 years ago

silvio commented 6 years ago

Now you can configure the PlantUML server at build time via

[...] --build-arg PLANTUMLSERVER="https://[...]/png/" [...]

Important: you need the last slash '/'!

Signed-off-by: Silvio Fricke silvio.fricke@gmail.com

schnatterer commented 6 years ago

Thanks, @silvio. Was that a real use case to you? Tested successfully.

I actually thought about including the plantUML server into smeagol-galore, so to get rid of the external dependency. But before I definitely have to split up into separate containers.

silvio commented 6 years ago

Thanks for integration.

My use case is that I don't want my data generated on an external server and have a own plantuml server already running...

schnatterer commented 6 years ago

Yeah, that's a really good point. The original smeagol also uses a local PlantUML instance from the cloudogu ecosystem at /plantuml. For smeagol-galore using the public plantUML was just a no-fuss approach to get started ;-)